Error in Key mode + No key offset column

[bascurtiz]

See: http://disq.us/p/1qbbdx5

Which version of Traktor do u use?

[bascurtiz]

Downgraded from v2.11.2 11 to v2.11.1 31 & all works FYI :)

[skymakai]

I'm on 2.11.2 11 with no issues seeing the Key Offset Column. (Mac)

[bascurtiz]

Thanks Skymakai. I updated thru Service Center installed Controller Editor 2.2.2 + Traktor 2.11.2 11 & errors are back using this Screen hack. Downgraded again to 2.11.1 31 & Screen hack works. So defo an issue with Windows variant. OS used: Win10 x64 [PC] + Kontrol S8 See examples: https://imgur.com/a/Uw1KN

[chronik78]

I have similar issue using the latest Traktor version and the previous version on the latest Mac OSX. The beat to cue is small and in the browse screen I don't have key offset. Essentially it doesn't look as pictured. It look like a similar version to the ErikMinekus mod but with things not working. Thanks for your help.

[bascurtiz]

@chronik78 Does it look like this? See examples: https://imgur.com/a/1WtXd

[kokernutz]

After a hiatus, I've started working on these mods again. Here is the current state... I'll publish what I have tomorrow!

[bascurtiz]

w00t! I'll be your test-bunny =)

[chronik78]

@bascurtiz yes looks exactly like that!

@kokernutz that would be awesome! From all the screens I've seen yours is the cleanest/most practical for the way I like to mix. Thanks for your efforts!

[kokernutz]

Uh oh... am I going overboard?

[bascurtiz]

SYNC + LOCK + CURRENT KEY = Awesome add-ons! These were a little hidden in previous built/Traktors built... though crucial info when altered! If possible, CURRENT KEY bg-color based on the corresponding key color Traktor uses, see: https://gyazo.com/5147e93a9775b26f768def7a66739d84

SYNC + LOCK color are already perfect.

BPM + PITCH = All good! LOOP INDICATOR = Great change in size. Right color when active. DECK INDICATOR = Great change in size. If possible, Blue when A or B, White when C or D. BEAT COUNTER = Since its fairly big, why not make this outline + text gray instead of blue?

What are the 4 blocks underneath BEAT COUNTER for? To show off the ONE-beat in a bar? If not, why not show the MASTER INDICATOR there? Overall pic would be something like this: https://imgur.com/a/y256m

[skymakai]

I agree. I like the layout of all the info in the header. But, I'd prefer everything to be darker.
Perhaps a colored outlines, but not filled color blocks. I don't want a jumble of colored blocks in the corner of my decks, unless they're indicating Key Lock is turned on, or some other indicator I need to remember to turn off. Another thing to consider is that the comments may overlap all that stuff, or be truncated, if they're too long. I don't need a beat counter, or a beat/bar/phrase countdown, but need to know which deck is the Master.

[kokernutz]

The deck indicator (A, B, C, D) is color coded correctly. (blue/white) The tempo and beat countdown is the same as the deck color.

And I agree about it being too busy visually. I'll work on making it less offensive. :)

The idea with the blocks below the beat countdown was to indicate which beat in the bar you were on. The orange outline matches the MASTER track and the green interior shows sync-ed tracks. I wanted to do it this way because I was always checking the other screen to make sure I was starting the track at the exact moment I needed to, and that microsecond delay of moving my eyes made me unsure of myself.

[skymakai]

One reason I preferred your mod over the others is it's simplicity and similarity to the original. Native Instruments left out some important stuff in their screens, and I'm grateful you're correcting that for me. There are other mods out there that emulate the Nexus and Denon controllers, and have every bell and whistle. As a seasoned DJ, there are only a few things I need to know quickly when looking at my Track deck header:
Original Tempo/Tempo Offset Sync/Master Key Lock On/Off.

Most other things can be easily seen on the controller or otherwise:

Loop On/Off+Length shows up on the controller (on/off), in the waveform, and when changing the length. I don't need it, though it doesn't take up much space in it's little circle.

Time Remaining is something I can tell by looking at the waveform and minute markers.

I put the Key in the Comments tag, so I already see that and don't need that.

I tend to use A/B for Track decks and C/D for Remix decks. So, I can easily tell which is which and don't need to have an indicator of which deck it is.. Plus, there's the Deck switch button on the D2/S5/S8 to easily go between the two.

I can see the beat counter being helpful for people who are more visually inclined. Personally, I use my ears and can easily tell what is a downbeat and what is an upbeat, and when a new bar starts. I don't need it and would prefer a more simple layout. Perhaps a fork of the project for Simple/Complex layouts would be good? Perhaps a comments section could describe which areas to comment out in order to activate/deactivate features?

What ever happened to 'user defined' preferences? Is that even possible?

[bascurtiz]

@skymakai I agree with the blocks filled with color.

@kokernutz How about this? SYNC + LOCK + LOOP on: https://imgur.com/a/7xrnB MASTER on + LOCK + LOOP off: https://imgur.com/a/iD2Jx

[kokernutz]

@skymakai All good points and thank you for your enthusiasm! Yes, prefs are still something I want to implement... I just successfully created the first one for displaying album art in the deck header.

I'm thinking at this point I should definitely create a branch to keep with the original spirit of my mods. Do you want to create a mockup (it can be as simple as a doodle) and I'll create it? You probably only need to grab the screenshot I posted yesterday (in this thread) and let me know what I should change.

@bascurtiz This is what I did:

[bascurtiz]

Looks good to me! I’d Love to test it out.

[kokernutz]

OK. I noticed the phase meter doesn't work when you've gone past your last cue point. Need to fix that.

@bascurtiz here you go...

Screens.zip

[bascurtiz]

@kokernutz Works great! Tested on Traktor 2.11.1 31 See: https://imgur.com/a/TfD9T

The beatphase is intelligent using that outline from the master, in the synced deck. Props. Perhaps make the fontsize smaller of the title , artist & comment?

Also, not sure if it's possible or if u understood my earlier proposal: The color coded key is showing. But if I alter the key from let's say 4A to 2A, would be cool if that color would jump from Yellow (=4A) to Green (=2A).

[kokernutz]

@bascurtiz Great. Yes, I need to figure out what I'm doing with the artist/title/comment section. It's the section I'm least happy with. And I can confirm that bug... I need to detect the change and update the color.

How'd you get the FX display at the bottom?

[bascurtiz]

@kokernutz FX is showing at the bottom by default, see when no track is on a deck: https://imgur.com/a/edpL7 I'm using a S8, on Win10, perhaps that makes the difference.

I'll now update Traktor to the latest version, to check if your updated screenhack is still working.

[kokernutz]

@bascurtiz Is that normal? I have an S5 and they slide down from the top when I touch the FX knobs. Also I'm running the latest Traktor on Mac. I would think there wouldn't be any different because this is just all Javascript and QML. Nothing Mac/PC specific.

Default S5 view:

[bascurtiz]

@kokernutz I think it's normal, since I can either change FX Bank 1 (on top) or FX Bank 3 (on bottom) on Left Deck (FX Bank 2 top / FX Bank 4 bottom on Right Deck), see pic where i'm touching a rotary knob on top + bottom at the same time: https://imgur.com/a/5gold

Tested with Traktor 2.11.2 11: Errors in keys are back. No key showing in the deck-section + Err in Deck A+B in Browser section + Err in Key-mode change. See: https://imgur.com/a/LPvoO

[chronik78]

@kokernutz Looks great! I tested the new version above. The play screen appears as pictured however I am still having similar issues to before with the browsing screen which has error and doesn't show the key shift column.

[kokernutz]

@bascurtiz Interesting. The function convert Open Key to Camelot is returning an ERR so we at least know it is being called. Is this all tracks? And your files have something in the "Key" column in the browser? Can you post a pic of your PC's Traktor file browser with that column shown?

[kokernutz]

@chronik78 Are you on a PC running the latest version of Traktor? 2.11.2 64-bit?

[bascurtiz]

@kokernutz This is on v2.11.1 31: https://gyazo.com/c9413b36151bd44971bef93d210044f3 That stuff doesnt change, with newer update I think, but I will update right now.

[kokernutz]

@bascurtiz The only thing I can think of at the moment is an upper/lowercase matching problem.

After you upgrade, and before you put the mods in place, can you find your Keylock.qml file and copy & paste this section into a new comment? (It's second from the bottom.) I'm curious if your text: field is different than mine.

  // key
  Text {
    anchors.top:              parent.top
    anchors.right:            parent.right
    anchors.topMargin:        67
    anchors.rightMargin:      20
    font.pixelSize:           fonts.largeFontSize
    font.family   :           "Pragmatica"
    font.capitalization: Font.AllUppercase
    color:                    colors.colorGrey104
    opacity: (keyDisplay.value=="") ? 0 : 1
    text:    "(" + keyDisplay.value + ((offset==0)?"":" ") + ")"
  }

[bascurtiz]

@kokernutz

// key Text { anchors.top: parent.top anchors.right: parent.right anchors.topMargin: 67 anchors.rightMargin: 20 font.pixelSize: fonts.largeFontSize font.family : "Pragmatica" font.capitalization: Font.AllUppercase color: colors.colorGrey104 opacity: (keyDisplay.value=="") ? 0 : 1 text: "(" + keyDisplay.value + ((offset==0)?"":" ") + ")" }

[bascurtiz]

@kokernutz Seems the same above, but check this out, the Key column is showing a different notation (without using your screenhack yet on the updated version):

https://gyazo.com/a8792d5ffa88952aceda3a81c348b5fd

[kokernutz]

@bascurtiz Hmph, same as mine. I'm stabbing in the dark since I don't have a PC. Can you try these files?

Screens.zip

[kokernutz]

@bascurtiz Eureka! Go to your prefs and make sure these options are set correctly:

[bascurtiz]

@kokernutz Haven't tried the last built out u just posted, but that's it! With new version it overwrites settings from Open Key to Musical. https://gyazo.com/58aa4a8eaa29afaa16255a79f79e2c23

After setting it back to Open Key, it simply works again \o/

[kokernutz]

@chronik78 make sure your options are set correctly.

If it works I will close this issue!

[chronik78]

@kokernutz I am using the latest version of Traktor and latest OSX. I changed the settings and this appears to have worked. Thanks guys! See below. Looks like this now. Is this right? I thought there was a column for key shift in an earlier version? Or was that removed? No biggie just curious.

[bascurtiz]

@chronik78 Make sure you have a track playing & push SHIFT + SYNC button on that deck to define it's the MASTER. Based on this current track (and its native KEY) it will now show you the KEY SHIFT column. When altering the KEY, the KEY SHIFT column will change based on the currently/changed KEY value.

[bascurtiz]

@kokernutz @skymakai I've made a more clean look, based on the default screen of Traktor, but incorporated your add-ons. I like it, since it takes less space + less jumble of colored blocks. Also added Original Tempo. Check it out: https://imgur.com/a/Uviap

[kokernutz]

@bascurtiz Looks good. I should be able to do that tonight.

In the meantime, here is a new version where I tightened everything up and fixed the bug so the key color now changes when you adjust the key. Also, check the Prefs.qml file! Just three options right now: display cover art, display comment, and display phase meter.

Screens.zip

[bascurtiz]

@kokernutz If you give me some clues, I can try to edit your QML files myself.

Tested new version:

• Color changing works as expected. Great!
• Prefs.qml is superhandy for those want adjust it to their likings. Awesome work.

[kokernutz]

@skymakai @bascurtiz

What do you think?

I turned off comment, phase meter and "outline mode".

readonly property bool displayAlbumCover: true readonly property bool displayPhaseMeter: false readonly property bool displayTrackComment: false readonly property bool outlineMode: false

[skymakai]

Looks good; clean and simple. How does it look without cover art? And how does it look with comments?
I'm concerned that comments may be truncated, as it looks like the title of the song is being truncated in your screenshot. My typical comments can look like this: *** 8B/9B - [Groover][Chiller]

[bascurtiz]

@kokernutz Yep, if you can size down the Cover art a bit like in my example + change the fontsize of title + artist + comment a bit, you're there! Though, I'd add the Original Tempo aswell, since that's important, as @skymakai already mentioned. The B from deck B is easily replacable with the PNG that comes natively. Just size it down to 50%. This way, all the values are not outlined in a filled colored box. Keep it going, preferably taking my example in check!

NOTE: To get more space, mind how the native/default screen takes less space between the rows. It works, since it uses a different color (from bright to dark) on every row. So I suggest to make row 1 light blue (as it is), row 2 darker blue (like artist but also Original Tempo + Pitch %) & row 3 would be COMMENTS + PhaseMeter, make em both grayish (Phase outlined gray) for ex. if possible + LOCK gray when inactive)

[kokernutz]

@skymakai @bascurtiz

OK I made some changes so the max characters that are displayed for the artist/title/comment adapt to the presence of album art and the phase meter.

[bascurtiz]

@kokernutz Looks about right. Now I'm curious if Coverart + Phase meter are enabled.

[kokernutz]

@bascurtiz

[skymakai]

Looking at that last picture, I get the idea that the Phase Meter should be on top/middle. It's size won't compete for space due to the Titles of songs being short.

[kokernutz]

@skymakai

On top of what?

I was wondering if the phase meter could be squeezed in between the deck header and the waveform. Or overlayed on top of it without being distracting.

Do we need to see the key in the deck header? I was wondering if we could remove key, move key lock up, then slide the phase meter and master/sync indicator over to the right. Or I could combine lock/key into one slot. I could replace the "LOCK" text with a little padlock graphic or something similar to save space.

I shrunk the album art and deck header by 6 pixels to tighten things up a bit. I don't want to get any more compact than this because my eyes aren't that great and the LCDs on these things suck.

[kokernutz]

Anyway, here are the screens as they are right now. I may need to do fixing the artist/title/comment sizing for stems. (Will test those tomorrow.) And the phase meter still needs work. (It doesn't work after you passed the last cue point.)

Screens.zip

[skymakai]

Sorry I wasn't clear enough. The phase meter is the widest element.
So, it makes sense for it to be where the beat counter is at. This is because there is more room to the right of the song Title; there is less room to the right of the Comments.

I like the idea of a symbol for Key Lock. ErikMinekus, who did the Nexus and Prime mods, shows the use of a Key Lock symbol in his Prime mod.

[skymakai]

And the phase meter still needs work. (It doesn't work after you passed the last cue point.)

This is because the phase meter counts down to the next Cue Point, right?

If the playhead is past the last Cue Point, what other behavior would you have it do?

[bascurtiz]

@kokernutz Nooo! Don't lose the CURRENT KEY to show. 1) Changing the KEY is kind of experimental, but can do wonders, though tricky: It looses punch & more than +2 or -2 will suck quality-wise. For ex. sure, u have mixed 1 track into the other based on its changed/current KEY; Now they work together. But then the next track, u forget KEY was changed & seek for the wrong track. 2) Ofcourse, the Column Shift KEY will help u out there, but then I again don't have direct overview, without having to push a button (which I disliked at native/default screen of NI). 3) It doesnt take that much space. 4) The fact u have made it to change color is neat!

LOCK Yes, u could size it down using a keylock icon, see attach. I've mimicked the LOCK-icon used in Traktor itself, see: https://gyazo.com/c30abef8692bced8b7701de84b647efc

keylock-screenhack.zip

PHASE METER For me personally, the COMMENT-tag has the least characters (just output of MIK). So PHASE METER works best on row 3. Otherwise, row 2 will do best, since most of the times the artist name is the shortest. ...Compared to a Title + (Bigroom 2017 Club Mix) for ex.

I did a re-edit incl. the KEYLOCK icon and made room for COMMENT. Example:

Attached the .PSD file, if u wanna do edits. master-screenhack-v2.zip