kokernutz / traktor-kontrol-screens

Replacement screens for the Native Instruments Traktor Kontrol D2, S5, and S8
102 stars 40 forks source link

Update for Traktor 3.11.0 by @JorgeHontoria - Browser Key Match Not Working #56

Closed skymakai closed 7 months ago

skymakai commented 8 months ago

Hello, @JorgeHontoria :) I recently found your fork (not committed yet, so I can't post an issue on your fork), and tested with the Kontrol S5. I found that the key match indicator isn't working at all, and some odd visual glitches (see attached images)

https://github.com/kokernutz/traktor-kontrol-screens/assets/15059021/a1d96a71-20c7-4e17-9f51-a10ceacde24d

https://github.com/kokernutz/traktor-kontrol-screens/assets/15059021/13589e3e-a336-4eee-8ea7-77c4a3b389fd

JorgeHontoria commented 7 months ago

I think I've figured out what was going wrong. ".track.content.entry_key" becomes ".content.legacy_key".

skymakai commented 7 months ago

Thank you! Do you have somewhere someone can send you a donation?

Unfortunately, looks like there's still a couple issues:

Is the Prefs.qml still being referred to for custom preferences?

IMG_1846

JorgeHontoria commented 7 months ago

Traktor S8 version 3.10.1.16 https://github.com/kokernutz/traktor-kontrol-screens/assets/6266381/6b3e6b2f-905d-4c30-9c80-8b4ded76783c

Source Code: https://github.com/JorgeHontoria/traktor-kontrol-screens

skymakai commented 7 months ago

I'm on Traktor version 3.11.0 (44). Perhaps there's been more changes since Traktor version 3.10.1 (16). I'll test that version against 3.11.0. I never downloaded 3.10, so I'll have to request that download from Native Instruments.

But, it looks like it's working on the S8... so it may be something about the S5 specific files that needs to be updated.
I figured the S8 and S5 use the same browser files.

JorgeHontoria commented 7 months ago

Supports Traktor 3.11.1.17 on S8. I have verified it. It is important to take into consideration that a deck must be active as MASTER (or activate AUTO).

I don't know how it will behave in D2 or S5. If someone donates me one I would make it functional without much delay.

skymakai commented 7 months ago

Updated to Traktor 3.11.1...Good news and bad news.

Almost there! I'm happy to test/troubleshoot on the S5. We can connect via Zoom and screen-share if needed.

IMG_1850

JorgeHontoria commented 7 months ago

I have made many changes to integrate as many community features as possible. Please download the new version (for traktor 3.10.x and 3.11.x) from New Version, try it and let me know if you have any unresolved problems.

Clicking on the star in the Git repository is appreciated.

skymakai commented 7 months ago

@JorgeHontoria Looking good.
Almost there... only thing I see wrong is the BPM column is now "randomly colored" when a track's key matches. (see image)

IMG_1987

skymakai commented 7 months ago

@JorgeHontoria Another example, showing master track's matching BPM:

IMG_1995

JorgeHontoria commented 7 months ago

Fixed

skymakai commented 7 months ago

@JorgeHontoria Fantastic work! Be sure to post your PayPal or Venmo so we can support you.

Another issue: Played tracks do not become 'dim' or indicate 'played'.

Image below shows a 'played' track still the same grey color as the other library tracks. IMG_2006

JorgeHontoria commented 7 months ago

Customizing a plugin like this is a lot of work, but I like to do it. I know quite well the technology behind Traktor and I think I can do a good job. I accept the challenge, I'm up for it. To start with I have opened a Patreon to improve it Patreon. The first patrons will be able to define the following three features to implement (I'm already working on two interesting ones).

skymakai commented 7 months ago

@JorgeHontoria I've just subscribed. Thank you for creating a way to support your work!

My hope is that the mod is maintained. I'm interested in new features, but not at the cost of stability. Note, I have tried the "Supreme Mod" and found that it changes too much from the defaults, and has graphical issues in the browser... likely because it's too bloated.

Did you see my previous reply about the Browser not dimming "played" tracks?

MrPatben8 commented 7 months ago

Hi @JorgeHontoria I wanted to thank you for all the amazing work you've been doing with this project, giving it the love it deserves. I contributed a little to the original repo a few years ago and still utilize this mod religiously (I have an S8 and 2x D2s) so I'm very happy to see that you've been helping keep this mod alive for newer Traktor versions. I have made some significant changes to my own fork of the mod (such as changing MixerFX flavor by using the FX channel assignment (arrow) buttons at the top of the S8 channels, amongst a bunch of other changes). And I wanted to know if you'd be open to discussing these modifications of mine and see if you might want to include them in your own fork of the mod. I think a lot of other users would benefit from these changes.

If you could enable the "Issues" section for your fork, I'd be happy to continue this conversation there.

Thanks again for your amazing work!

JorgeHontoria commented 7 months ago

I think the changes you made in the MOD are great that's why I have included part of them in the current fork (in the README.md I make reference to it). I would like to respect your work and include it for future versions. I would also like you to participate in the decisions of the future modifications (what better than you to decide the future of the MOD).

To verify that it is functionally to your liking, please download the current version of TraktorSimpleScreen from the Git repository and verifying the behavior of all your contributions (and some of mine and other community members) Git TraktorSimpleScreen. If you see any modification that is not included, let me know so I can include it.

In the future, the ideal is that we do the work in a coordinated way in the Patreon account (so that subscribers can decide on these issues), so I encourage you to subscribe and be part of the Early Patreon TraktorSimpleScreen.

I think we can continue the conversation in this thread without problems.

Thank you very much for all you have contributed.

MrPatben8 commented 7 months ago

@JorgeHontoria Sounds Great! See you over on Patreon!

skymakai commented 7 months ago

@JorgeHontoria The Patreon is a great way to converse, but we still need to enable "issues" on the Github repo. There's no way to post pics of issues on Patreon.

Issue - Cue, Loops, OFF Markers (2 images): Cue, Loop, Off Marker Cue, Loop, Off Marker 2

JorgeHontoria commented 7 months ago

Regarding the bugs, I think the best thing to do is to report them in the Git Issues repository, I have already activated it in the bugs section.

skymakai commented 7 months ago

Ah, good... thank you for enabling it.