koki / short

Manageable Kubernetes manifests through a composable, reusable syntax
https://docs.koki.io/short
Apache License 2.0
122 stars 14 forks source link

make sure conversions of string-constant types properly handle empty strings #189

Open ublubu opened 6 years ago

ublubu commented 6 years ago

In most (all? nearly all?) cases, it's valid for one of the type-alias-string fields to be empty. (by type-alias-string, i mean e.g. type PodConditionStatus string)

Make sure the conversion functions don't treat empty strings as a failure case.

Also, be sure to add test cases where fixes are made.