koki / short

Manageable Kubernetes manifests through a composable, reusable syntax
https://docs.koki.io/short
Apache License 2.0
122 stars 14 forks source link

Convert_Koki_Secret_to_Kube_v1_Secret is not populating the StringData #228

Closed msenmurugan closed 6 years ago

msenmurugan commented 6 years ago

There is an error in the Convert_Koki_Secret_to_Kube_v1_Secret for the field StringData https://github.com/koki/short/blob/master/converter/converters/secret.go in line 69, it is Actual kubeSecret.StringData = kubeSecret.StringData Expected kubeSecret.StringData = kokiSecret.StringData

Could you pls fix this issue?

wlan0 commented 6 years ago

Fixed by https://github.com/koki/short/pull/229