koki / short

Manageable Kubernetes manifests through a composable, reusable syntax
https://docs.koki.io/short
Apache License 2.0
122 stars 14 forks source link

koki selector match label is added by default during the creation of persistent volume claim #233

Open msenmurugan opened 6 years ago

msenmurugan commented 6 years ago

Issue: koki selector match label is added by default during the creation of persistent volume claim which is expecting the persistent volume to be labelled in the same way.

Expectation: Match labels should be added only if it is provided by the user

Actual: Match label is added by default

CC @rrati

msenmurugan commented 6 years ago

In koki_pvc_to_kube_pvc.go, revertPVCSpec calling revertRSSelector which provides the default match labels, it needs to be modified