search

koki / short

Manageable Kubernetes manifests through a composable, reusable syntax
https://docs.koki.io/short
Apache License 2.0
122 stars 14 forks source link

Fix for issue# 233 #234

Closed msenmurugan closed 6 years ago

msenmurugan commented 6 years ago

Fix for koki selector match label is added by default during the creation of persistent volume claim

wlan0 commented 6 years ago

This change breaks the API. Leaving this comment here to bump up the version and add this to release notes.

wlan0 commented 6 years ago

@msenmurugan Can you make sure the CI passes? I'll merge once that's done and Rob's comments are addressed

msenmurugan commented 6 years ago

@wlan0 In order to fix the CI build, I have commented the koki.selector labels in all testdata yamls. After this change, the functional test throws an error as "Missing pod spec". To fix the missing pod spec issue, I need to comment the below code in koki_rc_to_kube_v1_rc.go. After commenting the below code, all the issues are fixed except replication_controller_spec_without_template and replication_controllers/meta_test test scenario. 

func revertTemplate(kokiMeta *types.PodTemplateMeta, kokiSpec types.PodTemplate) (*v1.PodTemplateSpec, error) {
    var hasMeta = kokiMeta != nil
    var hasSpec = !reflect.DeepEqual(kokiSpec, types.PodTemplate{})
    if !hasMeta && !hasSpec {
        return nil, nil
    }

Can you please let me know whether the above check is required and also help me in fixing those two test scenarios?

wlan0 commented 6 years ago

LGTM