search

kokizzu / plv8js

Automatically exported from code.google.com/p/plv8js
Other
0 stars 0 forks source link

Cannot compile plv8 dynamic mode #59

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. compiled postgresql version 9.2.3 from source (OK)
2. compiled v8 from source Version 3.17.9 (OK)
3. trying to compile plv8 gives me an error

src# export V8_SRCDIR=/usr/src/v8
src# cd plv8js/
plv8js # make
...
plv8_type.cc:212:19: error: ‘class v8::Object’ has no member named 
‘GetPointerFromInternalField’

I'm using the current (11 march 2013) plv8 sources on a Linux Mint 13 Maya 64 
bit operating system, on an Intel i5 processor, 12 Gb RAM.

Original issue reported on code.google.com by braila...@gmail.com on 11 Mar 2013 at 9:08

GoogleCodeExporter commented 9 years ago 
Looks like GetPointerFromInternalField was removed in V8 version 3.16:

https://groups.google.com/forum/?fromgroups=#!searchin/v8-users/GetPointerFromIn
ternalField/v8-users/aaSY-02HWzA/MP4gRTyB6Z4J

Original comment by cwil...@gmail.com on 14 Mar 2013 at 2:29

GoogleCodeExporter commented 9 years ago 
Can you change the subject line to give a better description, ie "Getting error 
about GetPointerFromInternalField when compiling"?

Original comment by cwil...@gmail.com on 14 Mar 2013 at 2:30

GoogleCodeExporter commented 9 years ago 
I'll change the subject line ... only if I will knew how to do it! :-)
Didn't find some button/option to do that! :-(

Original comment by braila...@gmail.com on 14 Mar 2013 at 7:56

GoogleCodeExporter commented 9 years ago 
I was able to get this to build against the newer V8 by switching 
GetPointerFromInternalField to GetAlignedPointerFromInternalField. I saw no red 
flags with this but I'm unfamiliar with both the v8 and plv8 code bases. 

I was also able to run all of my plv8 functions with this switch.

Attached is a patch with the changes if anyone wants it.

Original comment by Nitro...@gmail.com on 14 Mar 2013 at 4:49

Attachments:

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
you can try "make static" instead of "make"

Original comment by zdenko.v...@gmail.com on 14 Mar 2013 at 10:45

GoogleCodeExporter commented 9 years ago 
"make static" gets me this:

../src/store-buffer.h:229:9: error: private field 'heap_' is not used 
[-Werror,-Wunused-private-field]
  Heap* heap_;
        ^
1 error generated.
make[3]: *** 
[/Users/cwilkes/Documents/workspace/plv8js/build/v8-3.14.5/out/native/obj.target
/v8_base/src/accessors.o] Error 1
make[2]: *** [native] Error 2
make[1]: *** [build/v8-3.14.5/out/native/libv8_snapshot.a] Error 2
make: *** [static] Error 2

which I can probably get around ...

Original comment by cwil...@gmail.com on 18 Mar 2013 at 1:09

GoogleCodeExporter commented 9 years ago 
Thanks Nitro ... , I was able to compile dynamic plv8 with your changes from 
GetPointerFromInternalField to GetAlignedPointerFromInternalField. Now it 
works! Hope that the next stable release of plv8 will include that patch. 
Thanks again!
Teo

Original comment by braila...@gmail.com on 18 Mar 2013 at 7:44

GoogleCodeExporter commented 9 years ago 
Great.  I'm planning to apply the patch for the next release.

Original comment by umi.tan...@gmail.com on 19 Mar 2013 at 7:37

GoogleCodeExporter commented 9 years ago 
Applied.  The patch broke the oldest supported v8 so I tried keep it for now.  
V8's API is terribly changing, so at some point in the future we'll need to 
think about the dependency issue.  Thanks for the patch anyway.

Original comment by umi.tan...@gmail.com on 9 Apr 2013 at 7:29

GoogleCodeExporter commented 9 years ago

Original comment by umi.tan...@gmail.com on 9 Apr 2013 at 7:29