Get `cmake --build --target install` working - Githubissues

kokkos / kokkos-comm

Experimental MPI Wrapper for Kokkos

https://kokkos.org/kokkos-comm/

Other

12 stars 9 forks source link

Get `cmake --build --target install` working #14

Closed cwpearson closed 5 months ago

cwpearson commented 5 months ago

Install the header files and CMake configuration files.
Add a CI check that builds unit tests and perf tests against the install
Treat unit_tests and perf_tests as separate CMake projects to facilitate install testing.
There are probably many problems with this that I don't know enough about CMake to foresee

original below

Install the header files and CMake configuration files.
Add a CI check that builds unit tests and perf tests against the install
Add a CMake configuration -DKokkosComm_INSTALL_TESTING=ON that uses find_package to find KokkosComm and then builds unit tests and perf tests against that
There are probably many problems with this that I don't know enough about CMake to foresee

cwpearson commented 5 months ago

I am a little skeptical about using mpicxx as a compiler. MPI does not require it and it can make things strange mixing with gpu compilers.

However, this change can be done in a separate PR if you prefer to ensure all part of the repository are updated.

I agree, let's tackle this in another PR. I created an issue: https://github.com/cwpearson/kokkos-comm/issues/17