search

kokkos / kokkos-comm

Experimental MPI Wrapper for Kokkos
https://kokkos.org/kokkos-comm/
Other
12 stars 9 forks source link

non-contiguous `Impl::irecv` #32

Closed cwpearson closed 2 months ago

cwpearson commented 4 months ago

Replacement for https://github.com/kokkos/kokkos-comm/pull/9

Add an interface to KokkosComm:Req to register a callable at wait(). Use that interface to invoke unpack operations (if needed) at wait(). Add packer_type to MpiArgs.

cwpearson commented 4 months ago

The unit test part of this is done better in https://github.com/kokkos/kokkos-comm/pull/37

dssgabriel commented 4 months ago

Hi @cwpearson, what is still missing for this PR to be merged?

cwpearson commented 4 months ago

@dssgabriel could you please review https://github.com/kokkos/kokkos-comm/pull/37 so that can go in. In the mean time, I can address some of the comments on this PR

dssgabriel commented 2 months ago

Apart from a review approval, is there anything else missing in this PR? It would be nice to have it merged 🙂

masterleinad commented 2 months ago

Apart from a review approval, is there anything else missing in this PR? It would be nice to have it merged 🙂

There are a lot of merge conflicts.