kokkos / kokkos-comm

Experimental MPI Wrapper for Kokkos
https://kokkos.org/kokkos-comm/
Other
14 stars 9 forks source link

Unit Tests call Impl::irecv , KokkosComm::irecv takes MPI_Request by value rather than reference #91

Open nicoleavans opened 3 months ago

nicoleavans commented 3 months ago

The unit tests passed when merging a broken implementation of KokkosComm::irecv because they directly call Impl::irecv, which works correctly.

https://github.com/kokkos/kokkos-comm/blob/dd3c5c4a734f85df770b90d4129aa1454264010b/src/KokkosComm.hpp#L39

I have submitted #90 to resolve this issue.

dssgabriel commented 3 months ago

Partially fixed in #92.