kokkos / kokkos-core-wiki

1 stars 44 forks source link

Remove unused DeviceVPointer and DeviceVTable pngs #530

Closed JBludau closed 3 months ago

JBludau commented 3 months ago

While doing #529 I found that the pngs with virtual tables and virtual pointers on the device are currently unused.

grep -nr 'VirtualFunctions-DeviceVPointer.png' ./source | wc -l
       0
grep -nr 'VirtualFunctions-DeviceVTable.png' ./source | wc -l
       0

We should think if we want to keep them.

dalg24 commented 3 months ago

What do you recommend? Do these figures convey information that is not captured by the other two images that are actually used or can we live w/o them? Also maybe describe/attach them so it is clearer how the ones you remove differ from the ones that stay.

JBludau commented 3 months ago

Your browser should show them if you go to files changed -> tree dots -> view file. But let's make it more convenient.

I am for deleting for two reasons:

image image

But:

I guess, the bottom line is: we could rework the page on virtual calls. The images could use the same names as the code examples and if we redo them they could visualize the explanation given in the text. I will propose something in a separate pr.