kokkos / kokkos-core-wiki

1 stars 44 forks source link

Parallel dispatch, remove duplicates: one word and one clause #535

Closed RL-S closed 2 months ago

RL-S commented 3 months ago

The first change is a correction, the other one is maybe a bit down to taste, but it seems easier to read and understand now. I would guess that in the code, KOKKOS_LAMBDA is probably defined in terms of KOKKOS_INLINE_FUNCTION anyway, e.g. like this:

#if (defined KOKKOS_ENABLE_CUDA) || (defined KOKKOS_ENABLE_HIP) // or additional conditions, e.g. __CUDA_ARCH__
#define KOKKOS_INLINE_FUNCTION __host__ __device__ inline
#else
#define KOKKOS_INLINE_FUNCTION inline
#endif

#define KOKKOS_LAMBDA KOKKOS_INLINE_FUNCTION [=]

If so, then the special meaning is referring to the same thing. If not, then maybe a clarification would be good.

ajpowelsnl commented 2 months ago

Hi @RL-S , @masterleinad -- I do hate to be a PR party pooper, but for now, we are 110% focused on revising the API guide, and not the Programming guide.

In the API Guide, our goals are (in loose order):

If you would like help getting up and running with the API Guide repo, please LMK, and I'll be happy to help. Again, I am sorry to be a PR party pooper.