Error handling let them know which line causes the error - Githubissues

kokkos / kokkos-fft

A shared-memory FFT for the Kokkos ecosystem

https://kokkosfft.readthedocs.io/

Other

21 stars 4 forks source link

Error handling let them know which line causes the error #80

Open yasahi-hpc opened 6 months ago

yasahi-hpc commented 2 months ago

Static assertion to Unary (fftshift, ifftshift) and Binary (Plan and fft functions) APIs.

[x] Exec space and memory space consistency (all)
[x] View rank and axes rank consistency (all)
[x] precision consistency (Binary)
[x] layout consistency (Binary)
[x] rank consistency (Binary)
[x] Introduce is_view_operatable_v for Unary operation
[x] Introduce are_views_operatable_v for Binary operation
[x] Introduce have_same_precision_v for Binary operation
[x] Introduce have_same_layout_v for Binary operation
[x] Introduce have_same_rank_v for Binary operation

Runtime assertion should be std::runtime_error with appropriate messages. If there is inconsistency in extents, we cannot operate FFT.

[x] Introduce a precondition wrapper
[x] replace assert with std::runtime_error
[x] Add runtime assertion to check choice of axes is applicable to a View

Examples to produce errors should be added. Display the expected assertions.

[ ] Add an awful example to produce errors

Add CI for C++20 build

[x] ~~CUDA~~, HIP and THREAD build with C++ 20