Why does `values_type` in `CrsMatrix` specify `LayoutRight` when it's a 1D view?

kokkos / kokkos-kernels

Kokkos C++ Performance Portability Programming Ecosystem: Math Kernels - Provides BLAS, Sparse BLAS and Graph Kernels

Other

304 stars 96 forks source link

Why does `values_type` in `CrsMatrix` specify `LayoutRight` when it's a 1D view? #1610

Closed cwpearson closed 1 year ago

cwpearson commented 1 year ago

https://github.com/kokkos/kokkos-kernels/blob/1efdeee44303910b4e3a64f21c902c7f0a407dc2/sparse/src/KokkosSparse_CrsMatrix.hpp#L429

lucbv commented 1 year ago

It's somewhat a mistake, it should really be a default_layout generated by our unification logic for ETI. In practice it is a 1D view so that's not an issue really.

jgfouca commented 1 year ago

@lucbv , I fixed this in my recent GMRES PR but I forgot to close this issue, sorry!