search

kokkos / kokkos-kernels

Kokkos C++ Performance Portability Programming Ecosystem: Math Kernels - Provides BLAS, Sparse BLAS and Graph Kernels
Other
304 stars 96 forks source link

Unit test headers are installed #2332

Open tpadioleau opened 3 weeks ago

tpadioleau commented 3 weeks ago

Hi,

I noticed that headers from some unit_test directories are installed. I suspect it is a mistake ?

The command grep -R "APPEND KK_INCLUDE_DIRS .*unit_test" from the top-level directory returns:

common/CMakeLists.txt:LIST(APPEND KK_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/common/unit_test)
ode/CMakeLists.txt:LIST(APPEND KK_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/ode/unit_test)
batched/CMakeLists.txt:LIST(APPEND KK_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/batched/dense/unit_test)
batched/CMakeLists.txt:LIST(APPEND KK_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/batched/sparse/unit_test)
lucbv commented 3 weeks ago

Okay, thanks for reporting this @tpadioleau I suspect we rarely install the library ourselves so we did not notice, if you want to create a PR with these changes that would be kind!

tpadioleau commented 3 weeks ago

Yes i will have a deeper look.