`KOKKOS_CUSPARSE_SAFE_CALL` has `KOKKOS_` prefix

kokkos / kokkos-kernels

Kokkos C++ Performance Portability Programming Ecosystem: Math Kernels - Provides BLAS, Sparse BLAS and Graph Kernels

Other

313 stars 98 forks source link

`KOKKOS_CUSPARSE_SAFE_CALL` has `KOKKOS_` prefix #2371

Open cwpearson opened 1 month ago

cwpearson commented 1 month ago

https://github.com/kokkos/kokkos-kernels/blob/c7df61d536c74effb3e4466b011f67f24e85f314/sparse/src/KokkosSparse_Utils_cusparse.hpp#L67-L69

Let's be good ecosystem partners and prefix this with KOKKOSSPARSE_ instead.

I personally don't think this should be part of our interface. Is this intentional? If so, let's use KOKKOSSPARSE_CUSPARSE_SAFE_CALL, otherwise let's deprecate it and use KOKKOSSPARSE_IMPL_CUSPPARSE_SAFE_CALL.

lucbv commented 1 month ago

I think the last option makes sense: KOKKOSSPARSE_IMPL_CUSPARSE_SAFE_CALL, eventually we should review what we are doing for other libraries like rocSPARSE, rocBLAS, etc...

cwpearson commented 1 month ago

Interestingly those other ones are either not KOKKOS_ or they have IMPL in the name, in which case I feel happy to just rename them. This is the one special case.