deprecate KOKKOS_CUSPARSE_SAFE_CALL -> KOKKOSPARSE_IMPL_CUSPARSE_SAFE_CALL

kokkos / kokkos-kernels

Kokkos C++ Performance Portability Programming Ecosystem: Math Kernels - Provides BLAS, Sparse BLAS and Graph Kernels

Other

313 stars 98 forks source link

deprecate KOKKOS_CUSPARSE_SAFE_CALL -> KOKKOSPARSE_IMPL_CUSPARSE_SAFE_CALL #2426

Open cwpearson opened 2 weeks ago

cwpearson commented 2 weeks ago

Fix for https://github.com/kokkos/kokkos-kernels/issues/2371

lucbv commented 2 weeks ago

Something strange going on in the mi210 without TPLs, the tests are all reporting a segfault. This might be a machine/workflow issue rather than an actual bug...

cwpearson commented 2 weeks ago

I used Visual Studio Code’s global search/replace, except for the area where I implemented the deprecation macro.

cwpearson commented 1 week ago

Looks like Trilinos has one use in Ifpack2:

https://github.com/trilinos/Trilinos/blob/8bded3a266b3aa18b5f9fd4f380b5136982b3c23/packages/ifpack2/src/Ifpack2_LocalSparseTriangularSolver_def.hpp#L678-L679