Open kyungjoo-kim opened 6 years ago
Labeled as bug, please relabel as enhancement if that is more appropriate.
I think this will be a revamp and require considerable work, let us not block Trilinos update with this.
Your number 3 is true: if you don't enable eti-only you can instantiate anything.
Currently, eti-only is not really optional. It should be eti-only to compile KK within a reasonable time. With eti-only option, it instanciates layout left and right and there is no mechanism to instanciate layout stride in the Makefile.kokkos-kernels. This may not be a problem but it could be problematic.
KK only provides eti-only interface. For example, if I want to use "dot" with layout stride views, I got the following undefined error
This is a reasonable use case and blas function either use tpls or kokkos native implementation for this case.
KK test suite only test eti-only interface. Test coverage is significantly reduced as we limit testing for eti data types and array layouts. When I remove eti-only, there are several test failures. e.g.,
I am not very familiar with eti system but KK should be compiled with different types of view combinations and when eti is not available, it should be able to redirect the code path to generic implementations.