Updating KokkosSparse.hpp?

kokkos / kokkos-kernels

Kokkos C++ Performance Portability Programming Ecosystem: Math Kernels - Provides BLAS, Sparse BLAS and Graph Kernels

Other

303 stars 96 forks source link

Updating KokkosSparse.hpp? #655

Open lucbv opened 4 years ago

lucbv commented 4 years ago

@srajama1 @ndellingwood @brian-kelley @vqd8a It seems that we might want to add new algorithms that were developed recently to that header:

KokkosSparse_spadd.hpp
KokkosSparse_spiluk.hpp
KokkosSparse_BlockCrsMatrix.hpp

Or we can just decide that the header should be deprecated if we do not want to maintain it?

ndellingwood commented 4 years ago

@lucbv fair question, looks like the file is used in tpetra:

:packages ndellin$ pwd
/Users/ndellin/Research/trilinos/Trilinos/packages

:packages ndellin$ git grep KokkosSparse.hpp
kokkos-kernels/src/sparse/KokkosSparse.hpp:/// \file KokkosSparse.hpp
tpetra/core/src/Tpetra_LocalCrsMatrixOperator_def.hpp:#include "KokkosSparse.hpp"

srajama1 commented 4 years ago

Can we keep the matrix header for the data structure, add another one for preconditioners, and one for matrix ops (spadd, spgemm etc.) ?