search

kokkos / kokkos-kernels

Kokkos C++ Performance Portability Programming Ecosystem: Math Kernels - Provides BLAS, Sparse BLAS and Graph Kernels
Other
304 stars 96 forks source link

Windows compilation of kokkos-kernels fails because popcount and least_set_bit are not defined #957

Closed jrobcary closed 2 years ago

jrobcary commented 3 years ago

D:\winsame\cary\vorpalall-dev1\trilinos\packages\kokkos-kernels\src\common\KokkosKernels_BitUtils.hpp(207): fatal error C1189: #error: "Popcount function is not defined for this compiler. Please report this with the compiler you are using to KokkosKernels." D:\winsame\cary\vorpalall-dev1\trilinos\packages\kokkos-kernels\src\common\KokkosKernels_IOUtils.hpp(428): error C2664: 'int _stat64i32(const char ,_stat64i32 )': cannot convert argument 2 from 'stat ' to '_stat64i32 '

I have these fixed in my fork. Would like to know how to test before submitting PR. Assume I should just build. Do kokkos-kernels build standalone? Is there a sample cmake invocation somewhere?

lucbv commented 3 years ago

@jrobcary we are not testing against windows compilers in our testing. Can you propose a PR for us to look at while we are looking at how we will test this. If you can build a release version with ETI, tests and examples on that would be a good place to start.

lucbv commented 3 years ago

@ndellingwood @e10harvey Do you guys know where we could test this?

jrobcary commented 3 years ago

I can submit a pull request if you like.  I just hate to waste your time.

On 5/5/2021 4:54 PM, Luc Berger wrote:

@ndellingwood https://github.com/ndellingwood @e10harvey https://github.com/e10harvey Do you guys know where we could test this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kokkos/kokkos-kernels/issues/957#issuecomment-833100523, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK72THAA4ZOJDZMWPOPR6TTMHEDTANCNFSM44F2DOWQ.

e10harvey commented 3 years ago

@ndellingwood @e10harvey Do you guys know where we could test this?

This can be tested via github actions: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources.

jrobcary commented 3 years ago

Cannot this be accepted if it passes on your test machines?

ndellingwood commented 3 years ago

Resolved by @jrobcary with PR #981