kokkos / kokkos-remote-spaces

Distributed View Extension for Kokkos
Other
43 stars 17 forks source link

mpi: use mpi get_accumulate as proxy for atomic add #100

Closed vmiheer closed 5 months ago

vmiheer commented 6 months ago

Partly fixes #99. I think for other functions ideally the imples for atomic should be deleted giving compile time error message to the user of krs/mpi. But atleast it should print warnings saying the library is using non-atomic operations for now.

Get_accumulate might be slightly inefficient than just Accumulate but c++ opeartor += should return the updated value, maybe it could return "optional" value, the access to which would error out.

janciesko commented 5 months ago

Superseded by https://github.com/kokkos/kokkos-remote-spaces/pull/103

vmiheer commented 5 months ago

Closing.