search

kokkos / kokkos-remote-spaces

Kokkos Remote Spaces implements distributed Kokkos Views and related APIs for distributed parallel programming.
Other
42 stars 17 forks source link

Compiler warning is_tiledlayout is deprecated #101

Open vmiheer opened 3 months ago

vmiheer commented 3 months ago

I found https://github.com/kokkos/kokkos/pull/6907 but I am not https://github.com/vmiheer/kokkos-remote-spaces/blob/56c3f9c07f2e7a05f76c939cbc2a08ba9b27f267/src/core/Kokkos_RemoteSpaces_DeepCopy.hpp#L580 and the deprecation notice does not specify the alternative.

I stumbled upon it trying to understand KRS + MPI build failure. This warning doesn't cause build failure but there is something in benchmarks/applications is causing it.

janciesko commented 3 months ago

Thanks, yes, I did notice this but was not able to get back to it timely. I should have a fix for this shortly.

janciesko commented 3 months ago

https://github.com/kokkos/kokkos-remote-spaces/pull/102 should fix those issues.

dalg24 commented 3 months ago

102 should fix those issues.

Mixing unrelated things into the same PR makes it difficult to audit changes. You should consider dedicate a PR to getting rid of code that was using is_tiledlayout.