kokkos / kokkos-remote-spaces

Distributed View Extension for Kokkos
Other
43 stars 17 forks source link

Convert cuda/nvshmem api to hip/rocshmem #69

Closed BKP closed 1 year ago

dalg24-jenkins commented 1 year ago

Can one of the admins verify this patch?

Rombur commented 1 year ago

OK to test

janciesko commented 1 year ago

Please run apply-clang-format to pass CI.

BKP commented 1 year ago

Please run apply-clang-format to pass CI.

Done.

I needed to change the version in the apply-clang-format file from version 8 to version 15 (on Frontier).

There were files in the other directories (shmem, nvshmem) that the apply-clang-format script updated. I only included the files in the rocshmem subdirectory in the pushed changesets.

janciesko commented 1 year ago

This still has a small formatting missmatch with our clang-format script.

janciesko commented 1 year ago

Let's make this merge contingent on passing unit tests on Crusher

BKP commented 1 year ago

Tests pass on both Crusher and Frontier.

janciesko commented 1 year ago

Thank you.