search

kokkos / kokkos-tools

Kokkos C++ Performance Portability Programming Ecosystem: Profiling and Debugging Tools
Other
109 stars 55 forks source link

GitHub CI: Don't use rocThrust in HIP builds #244

Closed masterleinad closed 6 months ago

masterleinad commented 6 months ago

The GitHub CI is failing since we are now expecting to find rocThrust for HIP by default in Kokkos develop. Fix this by not explicitly disabling support for rocThrust. Installing rocThrust would make the image too large for GitHub CI.

masterleinad commented 6 months ago

I don’t know if it’s obvious that rocThrust - a parallel algorithm library for AMD GPUs - is needed to do build testing of Kokkos Tools. Maybe we document or note it in the file of this commit what it is and that it’s needed. I wonder if there is a way to remove this dependency. It’s possible I am missing something.

I updated the pull request. It's easier to just disable rocThrust support.

vlkale commented 6 months ago

I don’t know if it’s obvious that rocThrust - a parallel algorithm library for AMD GPUs - is needed to do build testing of Kokkos Tools. Maybe we document or note it in the file of this commit what it is and that it’s needed. I wonder if there is a way to remove this dependency. It’s possible I am missing something.

I updated the pull request. It's easier to just disable rocThrust support.

Got it. Thanks! Yes, I think just disabling is adequate. I see it is passing the build testing now.

masterleinad commented 6 months ago

@vlkale ping Can you approve and merge? We can try building with rocThrust later if we deem that useful but it's annoying to have the CI fail.

romintomasetti commented 6 months ago

I think you need a second approval. @crtrott or @dalg24 ?