search

kokkos / kokkos-tutorials

Tutorials for the Kokkos C++ Performance Portability Programming Ecosystem
https://kokkos.org
Other
301 stars 100 forks source link

Update kokkos-kernels exercises build for post 3.0 #39

Closed ndellingwood closed 4 years ago

ndellingwood commented 4 years ago

Add script run_installlibs_cmake.sh to install kokkos, kokkos-kernels, then call cmake to generate Makefile for each exercise

ndellingwood commented 4 years ago

@jjwilke @srajama1 @brian-kelley @seheracer @lucbv @vqd8a @ e10harvey @kyungjoo-kim These changes add a script (and remove the broken Makefiles) to handle the kokkos-kernels exercises for version >= 3.0 - the scripts will install kokkos and kokkos-kernels, and call cmake to generate the makefile. Let me know if you have feedback, requests for changes, etc. before merge.

lucbv commented 4 years ago

Yeah that looks good to me. The only comment I have is that you are turning off the examples in kokkos-kernels' configuration which means that "example/wiki/sparse" examples won't compile even though we reference them in the tutorial slides.

ndellingwood commented 4 years ago

Yeah that looks good to me. The only comment I have is that you are turning off the examples in kokkos-kernels' configuration which means that "example/wiki/sparse" examples won't compile even though we reference them in the tutorial slides.

@lucbv I ran into a build error with tests disabled and examples enabled (something to do with gtest), I'll follow up with you to figure out what I should do different and we can reenable the examples once we get it resolved.

ndellingwood commented 4 years ago

Thanks all, merging this in for now to have a scripting option in place to compile the existing exercises. We can rename the scripts, enhance, split out capabilities etc as desired.