kokkos / kokkos-tutorials

Tutorials for the Kokkos C++ Performance Portability Programming Ecosystem
Other
271 stars 95 forks source link

Bug in simd exercise #56

Closed pkestene closed 1 year ago

pkestene commented 2 years ago

Hi,

I think there is a bug in simd_warp exercise:

data is a 2d View declared with the default memory layout, but it really should be declared with LeftLayout, so that memory is contiguous along extent(0).

I think the error was not seen because the input is initialized with constant data, and consequently the bug is neutral; but if you initilialized with non trivial data, one can see that the final result of test_simd and test_scalar are not the same.

I can provide a small fix for that if needed.

pkestene commented 1 year ago

fixed with #57