search

kokkos / kokkos-tutorials

Tutorials for the Kokkos C++ Performance Portability Programming Ecosystem
https://kokkos.org
Other
298 stars 100 forks source link

Fix KOKKOS_FUNCTION annotation for Neighbor::bindist in tools_minimd #99

Closed PhilipDeegan closed 5 months ago

PhilipDeegan commented 5 months ago

for #98

dalg24 commented 5 months ago

I feel like the right fix is to drop the markup at the declaration site https://github.com/kokkos/kokkos-tutorials/blob/b5774b6a3f075e53afe7e1789caf63cb5b68d2d8/Exercises/tools_minimd/neighbor.h#L133 The only use is in a host-only function https://github.com/kokkos/kokkos-tutorials/blob/b5774b6a3f075e53afe7e1789caf63cb5b68d2d8/Exercises/tools_minimd/neighbor.cpp#L824

PhilipDeegan commented 5 months ago

@dalg24 I'll test it

seems ok, updated