search

kokkos / kokkos.github.io

Source code for kokkos.org pages
https://kokkos.org
1 stars 12 forks source link

Fix logo top left #10

Closed antoinemeyer5 closed 1 year ago

antoinemeyer5 commented 1 year ago

Fix #4

The error came from the way I was managing the logo and its memory location in the code.

The error was hidden because the way Github deploys code is different for the antoinemeyer5/antoinemeyer5.github.io repository and the antoinemeyer5/kokkos.github.io repository.

In the first case, the URL is https://antoinemeyer5.github.io/, while in the second case the URL is https://antoinemeyer5.github.io/kokkos.github.io/

During development, I worked on the second repository with the second URL. I therefore masked my error. When you merged the work, the change of repository type (from the "second type" to the "first type" because here is kokkos/kokkos.github.io) + my error meant that the logo was no longer visible.

The error should now be fixed with this PR ✅

Before on kokkos/kokkos.github.io After on antoinemeyer5/antoinemeyer5.github.io = kokkos/kokkos.github.io
image image
image image
dalg24 commented 1 year ago

Please explain how removing the file layouts/partials/assets/navbar.html fixes the issue.

antoinemeyer5 commented 1 year ago

Please explain how removing the file layouts/partials/assets/navbar.html fixes the issue.

As I said earlier, during development I worked on a repository that didn't have exactly the same file architecture. To ensure that the logo was displayed correctly, I had to add the navbar.html file and modify it. By doing this I overrode the normal behaviour of the template's navbar.html file.

This subsequently led to the problems described above. It was a bad idea and a mistake on my part.

So I'm removing this file and simply reverting to the template's normal behaviour. The configuration of the logo in the navigation bar is in /config/_default/params.toml

This change corrects the problem, simplifies the code and better respects the template.