Work around __make_dynamic_extent compiler bug

kokkos / mdspan

Reference implementation of mdspan targeting C++23

Other

415 stars 69 forks source link

Work around __make_dynamic_extent compiler bug #182

Closed mhoemmen closed 2 years ago

mhoemmen commented 2 years ago

Some compilers can't do CTAD correctly with extents. Replacing __make_dynamic_extent<IndexTypes>() with an explicit expression in the deduction guide's parameter pack expansion works around the issue.

The resulting change means that nothing in mdspan uses __make_dynamic_extent. I've left __make_dynamic_extent defined, just in case downstream projects rely on it.

Fixes #177. @youyu3

crtrott commented 2 years ago

Lets delete that thing. Nobody should start to rely on things in detail with two underscores as start characters. Better they learn that now.

mhoemmen commented 2 years ago

@crtrott I removed __make_dynamic_extent and __make_dynamic_extent_integral -- thanks!