search

kokkos / mdspan

Reference implementation of mdspan targeting C++23
Other
413 stars 69 forks source link

mdspan fails to compile when compiler supports concepts but doesn't have <concepts> #273

Closed J-Meyers closed 1 year ago

J-Meyers commented 1 year ago

Currently layout_stride.hpp has an include of \<concepts> if MDSPAN_HAS_CXX_20 and MDSPAN_USE_CONCEPTS is defined, MD_SPAN_USE_CONCEPTS only checks that the compiler supports concepts by checking __cpp_concepts, but does not check that the standard library includes concepts with __cpp_lib_concepts

Example of failure on godbolt: https://godbolt.org/z/hejnYWxqq

I wonder if this may be related to the comment on line 124 of config.hpp, godbolt does not seem to have the HIP compiler so I was unable to test