search

kokkos / mdspan

Reference implementation of mdspan targeting C++23
Other
398 stars 65 forks source link

Fix warnings (shadow and conversion) #340

Closed crtrott closed 2 months ago

crtrott commented 2 months ago

The extent and stride thing shadow something new in utility.hpp

nmm0 commented 2 months ago

I don't think our CI is actually testing Wshadow

masterleinad commented 2 months ago

I don't think our CI is actually testing Wshadow

Looks like the GitHub Workflows don't test with any warning flags and https://github.com/kokkos/mdspan/blob/stable/README.md#running-tests mentions that a lot of the configurations would not build with warnings as errors (depending on the C++ standard).

crtrott commented 2 months ago

I don't think our CI is actually testing Wshadow

I know. But we can touch CI separately.