It turns out that the builds in cmake.yml are mostly fine with -Werror -Wall -Wextra -pedantic:
We get a bunch of warnings for unused variables building in RelWithDebInfo since that uses -DNDEBUG disabling a lot of asserts. Since we want these asserts to trigger, I changed the build type to Debug.
clang complains about -Wc++17-attribute-extensions when using [[maybe_unused]] which seems harmless.
clang complains about using variadic macros with empty ellipsis via -Wno-gnu-zero-variadic-macro-arguments which also seems harmless
The other changes are about redundant semicolons or unused arguments.
It turns out that the builds in
cmake.ymlare mostly fine with-Werror -Wall -Wextra -pedantic:RelWithDebInfosince that uses-DNDEBUGdisabling a lot of asserts. Since we want these asserts to trigger, I changed the build type toDebug.clangcomplains about-Wc++17-attribute-extensionswhen using[[maybe_unused]]which seems harmless.clangcomplains about using variadic macros with empty ellipsis via-Wno-gnu-zero-variadic-macro-argumentswhich also seems harmless