kokkos / pykokkos-base

Python bindings for data interoperability with Kokkos (View, DynRankView)
Other
26 stars 9 forks source link

DEV: allow non-squash merges #42

Open tylerjereddy opened 2 years ago

tylerjereddy commented 2 years ago

Looks like the repo doesn't allow individual commits in a PR branch to be preserved on merging (see below). The debate around this stuff isn't super interesting, but I'd argue that leaving the decision about whether individual commits in a branch merit preservation is best left to the reviewer/merger, rather than having a hard-block at the repo level. Sometimes individual commits are complex and have well-written commit messages, and could be productively revisited later on, etc.

image

Also, pykokkos repo doesn't have this restriction, FWIW.