kokkos / pykokkos-base

Python bindings for data interoperability with Kokkos (View, DynRankView)
Other
26 stars 9 forks source link

Fix Kokkos header includes #45

Closed dalg24 closed 2 years ago

dalg24 commented 2 years ago

Related to kokkos/kokkos#5178

tylerjereddy commented 2 years ago

The kokkos.__file__ being None in the failing job may be a separate matter I suppose, I see that in gh-43 as well.

dalg24 commented 2 years ago

The kokkos.__file__ being None in the failing job may be a separate matter I suppose, I see that in gh-43 as well.

Can you please handle it? You are welcome to push to my branch as necessary.

jrmadsen commented 2 years ago

I think you usually get __file__ = None when you import a directory that exists but doesn't have an __init__.py. Since only the pip install is failing, I'd recommend looking at where pip is putting the files

tylerjereddy commented 2 years ago

Is it normal for the Build stage to run in just 15 seconds? We don't expect a bit of CMake output for the Python 3.7 entry where we're not building from external pykokkos?

jrmadsen commented 2 years ago

Is it normal for the Build stage to run in just 15 seconds? We don't expect a bit of CMake output for the Python 3.7 entry where we're not building from external pykokkos?

That's definitely wrong. It looks like CMake might have gotten configured but it definitely didn't compile anything.

I see this line in the log:

https://github.com/kokkos/pykokkos-base/blob/87290b3c951fdf75b5280ed98e895024a4544126/setup.py#L193

https://github.com/kokkos/pykokkos-base/runs/8101209452?check_suite_focus=true#step:6:128

but nothing else.

tylerjereddy commented 2 years ago

thanks, I'll try to debug a bit more tomorrow

tylerjereddy commented 2 years ago

Alright, it looks like this has core developer approval, is also submitted by a core developer, and I've only made a minor contribution to pin a bad dependency, so I'll go ahead and merge now that CI is passing so that we can start to push other efforts forward with passing CI for the project.