Tasks Required for Promotion to Kokkos core

kokkos / simd-math

Library for length agnostic SIMD intrinsic support and the corresponding math operations

Other

20 stars 10 forks source link

Tasks Required for Promotion to Kokkos core #21

Open jeffmiles63 opened 4 years ago

jeffmiles63 commented 4 years ago

Below is a list of features and additions required to prepared simd-math for Kokkos promotion:

[ ] CMake build elements
[ ] Unit test suite which is build friendly
[ ] Testing scripts to validate on hardware/compiler matrix
[ ] features previously outlined in #1
[x] missing operators listed in #4
[ ] #15
[x] #16
[ ] features for core integration ( #22 )

edited by @ibaned to add checkboxes

jeffmiles63 commented 4 years ago

@ibaned @alanw0 @bjoo @crtrott Please review the list and comment. A meeting to discuss priorities and schedule may be valuable as well.

alanw0 commented 4 years ago

I want to include Timothy here, he's been involved a lot in getting this integrated into stk. @tasmith4

ibaned commented 4 years ago

@jeffmiles63 shouldn't #22 be something that is addressed in the kokkos/kokkos repository after these headers are merged into it? We can't really develop things on top of Kokkos execution spaces in this repository.

tasmith4 commented 4 years ago

Seems like #15 is effectively equivalent to the second and third boxes above (unit tests and testing scripts over a range of hardware/compilers)?

We have been cleaning up our unit tests on the stk_simd side, and we have some templated test fixtures which I think would translate to this repo without too much effort. If you're interested I can point you to the appropriate files in STK.

I commented in more detail on #1 regarding what needs to be done to eliminate the need for stk_simd.

jeffmiles63 commented 4 years ago

@ibaned I agree #22 will addressed in a separate PR in the Kokkos core. i thought the discussion should originate here.

jeffmiles63 commented 4 years ago

@tasmith4 if you have appropriate test fixtures we can start with that would be a great help.

tasmith4 commented 4 years ago

@jeffmiles63 I was going to point you to Trilinos but I see we haven't gotten the latest updates there yet. I will submit another snapshot PR by tonight unless @alanw0 beats me to it.

alanw0 commented 4 years ago

@tasmith4 I'm not going to beat you to it. I'm up to my eye-balls trying to debug the vortex stuff that empire is up against...

tasmith4 commented 4 years ago

@jeffmiles63 check out packages/stk/stk_unit_tests/stk_simd in Trilinos/develop. There's a couple things that might need to be tweaked or extended to test the whole range of functionality (our new unit tests are not yet complete, we have a story on this sprint to wrap that up), but hopefully this is a helpful starting point. Let me know if you have questions.

jeffmiles63 commented 4 years ago

@tasmith4 thanks for the update.

alanw0 commented 4 years ago

@jeffmiles63 Unfortunately I have a pull-request in progress to revert that code that @tasmith4 refers to above... It has a problem with cmake/install which has broken nalu and nalu-wind. We'll have it fixed and back in shortly though.