kokkos / simd-math

Library for length agnostic SIMD intrinsic support and the corresponding math operations
Other
20 stars 10 forks source link

Dan, here are the changes I needed so far. #3

Closed alanw0 closed 4 years ago

alanw0 commented 4 years ago

It looks like we'll also need the simd_mask(bool) constructor for avx512, neon and vsx but I haven't done a build on those architectures yet.

I'll also start an issue to discuss some operators and other stuff we might need.

ibaned commented 4 years ago

sounds good! the simd_mask constructors from boolean we should definitely do for all backends. let me explore the always_inline errors to see if they can be helped.

alanw0 commented 4 years ago

Let me know if you have trouble reproducing the always_inline errors. Perhaps it is something caused by the stk-simd layers above... I googled always_inline and it has been in gcc for a long time, so presumably it doesn't require c++14 or anything. In sierra we're just using c++11.

ibaned commented 4 years ago

I just realized I'd put a bunch of additional inline keywords to help with this in the copy of the file I had in my code. I just made the two copies consistent, let me know if things look any better.

alanw0 commented 4 years ago

ok great. I think I'll close this PR, pull down your updates, and then put up a new one.