Closed mzuzek closed 2 years ago
@mhoemmen @fnrizzi
Does symmetric_matrix_rank_2k_update()
allow A.extent(1) != C.extent(0)
or B.extent(0) != C.extent(0)
?
A.extent(1) > B.extent(1)
with k
going out of bounds in B(i,k)
?A.extent(1)
or B.extent(0)
- underconstrained ? And what would be the reason for the description to distinguish between k1
and k2
, with their respective domains ?@MikolajZuzek You're absolutely right -- I totally forgot to include that in the Preconditions (for dynamic extents) and Mandates (for static extents). I'll file an issue. DSYR2K
documents that A and B need to have the same number of columns K. I would certainly welcome fixes to the reference implementation.
Thanks @mhoemmen for the clarification!
If C
is NxN and A
,B
are NxK then incorrect Precondition B.extent(1) equals C.extent(0)
should be replaced with B.extent(0) equals C.extent(0)
and new one A.extent(1) equals B.extent(1)
should be added, right ?
PS. Seems like the hermitian variant suffers from the same issue, so I took the liberty to update #201 title.
@MikolajZuzek Please contact me offline if you would like to be credited in the proposal for finding this issue, and if so, whether you would like to supply an affiliation and/or e-mail address. Thanks!
This PR introduces Kokkos implementation and unit test for
symmetric_matrix_rank_2k_update()
andhermitian_matrix_rank_2k_update()
.