search

kokkos / stdBLAS

Reference Implementation for stdBLAS
Other
127 stars 22 forks source link

kokkos: `matrix_vector_product_lower` test failing #223

Closed mzuzek closed 2 years ago

mzuzek commented 2 years ago

@mhoemmen @fnrizzi

utest_{overwriting,updating}_{symmetric,hermitian}_matrix_vector_product_lower tests failed on CI job:

38/69 Test #38: utest_overwriting_symmetric_matrix_vector_product_lower ....***Failed  Error regular expression found in output. Regex=[[^a-z]Error]  0.02 sec
-- Found UnixCommands: /usr/bin/bash  
numerical test succeeded
CMake Error at /home/runner/work/stdBLAS/stdBLAS/src/stdblas/tests/kokkos-based/test.cmake:24 (message):
  test failed: overwriting_symmetric_matrix_vector_product did not call the
  correct Kokkos impl

and then on the re-run of the same job they passed fine, which suggests this failure happens randomly...

fnrizzi commented 2 years ago

Interesting this only happens for lower

fnrizzi commented 2 years ago

Are you able to reproduce on your machine? Or just the CI fails?

mzuzek commented 2 years ago

@fnrizzi Yes, I reproduced this locally and it happens for both lower and upper: the easiest way to reproduce is to execute the tests in parallel, like:

ctest -j 8 -R "(lower|upper)"

Please see the fix proposed on #228.