search

kokkos / stdBLAS

Reference Implementation for stdBLAS
Other
118 stars 22 forks source link

github action does not use mdspan SHA1 correctly #237

Closed mhoemmen closed 2 years ago

mhoemmen commented 2 years ago

In PR #234, we had to change the mdspan key (in .github/workflows/cmake.yml) so that the PR testing wouldn't always pick up an old mdspan (with the wrong tag, stable instead of mdspan-0.3.0). The workflow output suggested that for key: mdspan-${{ steps.get-sha.outputs.sha }}, the key was evaluating to mdspan-null. Thus, it could be that the code for getting the SHA1 is broken. If we don't fix this, then we'll never be able to test stdBLAS against the latest mdspan; it will always hit the cache, unless we change it manually (as we had to do in PR #234).

mhoemmen commented 2 years ago

I temporarily worked around this issue by changing stdBLAS to use the latest ("stable" branch) mdspan. However, I would still like to fix this.