The sequential implementation of triangular_matrix_matrix_solve for the lower triangular, right side case had a j loop that was counting in the wrong direction: up, instead of down. This commit fixes that, and adds a regression test. The test also uncovered a compilation bug that this commit fixes.
I also took the opportunity to explore a new design for avoiding duplicated code in defining template parameters and their corresponding function parameters.
@youyu3
The sequential implementation of
triangular_matrix_matrix_solvefor the lower triangular, right side case had a j loop that was counting in the wrong direction: up, instead of down. This commit fixes that, and adds a regression test. The test also uncovered a compilation bug that this commit fixes.I also took the opportunity to explore a new design for avoiding duplicated code in defining template parameters and their corresponding function parameters.
In addition, I added a commit that fixes #246.
Fixes #244 and #246.