search

kokkos / stdBLAS

Reference Implementation for stdBLAS
Other
127 stars 22 forks source link

Fix C++23 build (GCC 13.1.0) #253

Closed mhoemmen closed 1 year ago

mhoemmen commented 1 year ago

Fix tests and examples to build with C++23, using GCC 13.1.0.

I set the following CMake options.

cmake ${SOME_SOURCE_DIRECTORY_ROOT}/stdBLAS \
  -DCMAKE_CXX_COMPILER=${PATH_TO_LOCAL_GCC}/bin/g++ \
  -DCMAKE_C_COMPILER=${PATH_TO_LOCAL_GCC}/bin/gcc \
  -DLINALG_ENABLE_TESTS=ON \
  -DLINALG_ENABLE_EXAMPLES=ON \
  -DLINALG_CXX_STANDARD=23

where SOME_SOURCE_DIRECTORY_ROOT is the parent directory of my stdBLAS source checkout, and PATH_TO_LOCAL_GCC is the installation directory of my local GCC 13.1.0 build.

mhoemmen commented 1 year ago

The test appears to be failing because it can't find GCC's shared libraries. @amklinv-nnl would you happen to know about this? (Thanks! : - ) )

amklinv-nnl commented 1 year ago

The test appears to be failing because it can't find GCC's shared libraries. @amklinv-nnl would you happen to know about this? (Thanks! : - ) )

I sure would! It's because the test is trying to use a container with a different gcc version. My PR fixes that problem.