search

kokkos / stdBLAS

Reference Implementation for stdBLAS
Other
118 stars 22 forks source link

Fix TBB build issue #254

Closed amklinv-nnl closed 1 year ago

amklinv-nnl commented 1 year ago

@mhoemmen Please review #252 first since this PR sits on top of it.

mhoemmen commented 1 year ago

@amklinv-nnl Sorry for the trouble, but would you mind if I rebased these changes atop PR #253 instead of PR #252? #253 has less code duplication and avoids exposing namespace macros to the test files themselves. Thanks!

amklinv-nnl commented 1 year ago

@amklinv-nnl Sorry for the trouble, but would you mind if I rebased these changes atop PR #253 instead of PR #252? #253 has less code duplication and avoids exposing namespace macros to the test files themselves. Thanks!

Please rebase/resolve these PRs in whatever way makes you happy :-)

mhoemmen commented 1 year ago

This PR is superseded by PR https://github.com/kokkos/stdBLAS/pull/256 , which incorporates all of @amklinv-nnl 's changes except the new execpolicy_mapper overload (which would best be reserved for a subsequent PR that does an actual std::execution::* overload). Thanks to @amklinv-nnl for the implementation!