search

kokkos / stdBLAS

Reference Implementation for stdBLAS
Other
118 stars 22 forks source link

Implement P3222R0 and P3050R1 #268

Open mhoemmen opened 5 months ago

mhoemmen commented 5 months ago

Implement P3222R0 ("Add transposed special cases for P2642 layouts"). The corresponding paper PR is https://github.com/ORNL/cpp-proposals-pub/issues/448. Add tests for previously supported cases and the new cases.

Implement P3050R1 ("Optimize linalg::conjugated for noncomplex value types") and add tests. That is, fix conjugated for non-arithmetic, non-(custom complex) types. A type T is "custom complex" if conj(T) is ADL-findable.

Fixes https://github.com/kokkos/stdBLAS/issues/267 .

mhoemmen commented 5 months ago

Hi @dalg24 ! Thanks for your review!

I would prefer if you did not mix in the refactor/fixes with the implementation of the new feature.

It's actually impossible to pass the repository's automated premerge tests without the fixes, as the build fails.

Each commit is atomic (it builds and passes tests locally) and can be examined separately.

dalg24 commented 5 months ago

Can't you open another PR with the fixes only?

mhoemmen commented 5 months ago

Can't you open another PR with the fixes only?

There are lots of fixes. They are separated into different commits.

The current state of the repo is broken; it fails to build.

mhoemmen commented 5 months ago

@dalg24 Per your request, I've created PR #269 that only fixes the build and Standard conformance issues, without adding new features.

This PR is rebased atop PR #269, because (as mentioned before) this repository's build is currently broken, so it's impossible to pass check-in tests without the build fixes. Please merge PR #269 first.