Fix rank_k implementation

kokkos / stdBLAS

Reference Implementation for stdBLAS

Other

127 stars 22 forks source link

Fix rank_k implementation #275

Closed rasolca closed 3 months ago

rasolca commented 3 months ago

The implementation of symmetric_matrix_rank_k_update and hermitian_matrix_rank_k_update are wrong.

See xSYRK or xHERK for reference. (E.g. DSYRK)

Fixes #272

mhoemmen commented 3 months ago

Thanks for contributing! We'll review this as soon as we can.

mhoemmen commented 3 months ago

I'm able to reproduce the static_assert locally on the main branch. I'll fix that first.

UPDATE: Result of the offending submdspan is layout_right_padded. Test broke likely due to mdspan now having layout_right_padded fully integrated. That's not a bug if true.