koko1000ban / SublimeGtags

GNU GLOBAL(gtags) support for Sublime Text 2/3
21 stars 19 forks source link

Fix deadlock in TagSubprocess #7

Closed pitkali closed 12 years ago

pitkali commented 12 years ago

According to Subprocess documentation Popen.wait may deadlock when generating output and pipe buffer is filled. It was, however, called when generating tags before communicate(), and indeed breaking tags rebuilding when there were errors to report.

Now only communicate() is used for retrieving error data, and return code is read from the Popen object property.

Fixes #6

koko1000ban commented 12 years ago

Merged. thanks :)