search

kokorin / Jaffree

______ Stop the War in Ukraine! _______ Java ffmpeg and ffprobe command-line wrapper
Apache License 2.0
471 stars 80 forks source link

Fixes for recent FFmpeg versions #394

Closed jonfryd closed 1 month ago

jonfryd commented 2 months ago
  1. Fixes an issue with parsing the kilobyte unit (KiB) in newer FFmpeg versions.
  2. Fixed the testExceptionIsThrownIfFfmpegExitsWithError unit test (again, because the output has recently changed).
  3. I noticed a regression in my own software and added testFrameCountingWithStreamCopyAndProgressListener to test frame counting while performing a stream copy. It runs as expected on older FFmpeg versions but fails with recent versions (6.1.x and 7.0.x) due to a bug (which was fixed a week ago on their master branch).
kokorin commented 1 month ago

@jonfryd it looks like test failures are not related to this PR, right? Probably I have to revisit testing approach in favor of cross ffmpeg version testing instead of testing against latest version. But then cross Java version testing should be dropped. Otherwise it would require too many resources.

kokorin commented 1 month ago

I will merge this PR, but not sure when the next release will be. As mentioned, current issues should be fixed first.

jonfryd commented 1 month ago

@jonfryd it looks like test failures are not related to this PR, right? Probably I have to revisit testing approach in favor of cross ffmpeg version testing instead of testing against latest version. But then cross Java version testing should be dropped. Otherwise it would require too many resources.

Correct, the test failures are not related. I noticed Mac OS and Windows builds seem to be failing for all active PRs for some reason (didn’t look into it).

Yeah, a pragmatic trade off is necessary like you say. It is not practical to test all platforms and many FFmpeg versions on every build.

jonfryd commented 1 month ago

I will merge this PR, but not sure when the next release will be. As mentioned, current issues should be fixed first.

OK, sounds good. We’re sticking with FFmpeg 6.0 for now anyway. Take your time.

Thanks for your help. Have a good weekend!

kokorin commented 1 month ago

@jonfryd I have rebased this PR on top of develop branch and changed target branch to develop too.

kokorin commented 1 month ago

@jonfryd https://github.com/kokorin/Jaffree/releases/tag/R2024.08.29