search

kokororin / vscode-phpfmt

Integrates phpfmt into VS Code
https://marketplace.visualstudio.com/items?itemName=kokororin.vscode-phpfmt
BSD 3-Clause "New" or "Revised" License
130 stars 30 forks source link

Incorrect `php -v` os exec error check #129

Closed d-enk closed 10 months ago

d-enk commented 10 months ago

https://github.com/kokororin/vscode-phpfmt/blob/92aafa0500135a22f707dda6f00ede6ac408251c/src/PHPFmt.ts#L201-L208

This is where you should check the error code, not stderr. Because it just might contain harmless warnings.

kokororin commented 10 months ago

Thanks, fixed in 1.1.35