SpaceAroundParentheses creates adds two space chars for nested parentheses

[PrinceOfAbyss]

My settings JSON in regard to phpfmt formatting has the following array:

"phpfmt.passes": [
    "AlignDoubleArrow",
    "AutoPreincrement",
    "DoubleToSingleQuote",
    //"LongArray",
    "ShortArray",
    "SpaceAroundParentheses",
    "SpaceAfterExclamationMark",
],

My problem is that SpaceAroundParentheses, as its name implies, literally adds one space char after the first paren, and then adds one more before the second parent, thus resulting in two, consequent space chars between the two opening parens. Of course I may be wrong, but this seems like the most probable scenario to me.

So, if that's the case, I think that SpaceAroundParentheses should function more like SpaceAroundParenthesesInternally, in order to add a space char after (inside) the first opening paren, then add one more after (again inside) the second opening paren, and then add one before each of the closing parens (still inside them).

So to give you and example of the problem, this:

        if ( ( $min <= $cart_item['data']->get_weight() ) && ( $cart_item['data']->get_weight() < $max ) ) {

after formatting becomes like this:

        if (  ( $min <= $cart_item['data']->get_weight() ) && ( $cart_item['data']->get_weight() < $max ) ) {

[driade]

Hi @PrinceOfAbyss , thank you very much.

This is a very old rule many people use and we can't change neither its name nor its behavior. It's totally optional to use it or not.

If this rule doesn't fit your needs, maybe you could propose another one to be implemented.

[PrinceOfAbyss]

Hello @driade , thank you for your reply.

Since this rule can't be changed, the next best thing would be a new rule along the lines I mentioned in my first post. That is, something that will add spaces only inside two parentheses, named ie. SpaceInsideParentheses or SpaceAroundParenthesesInternally, etc...

Something that will change this: if (($min <= $cart_item['data']->get_weight()) && ($cart_item['data']->get_weight() < $max)) {

to this: if ( ( $min <= $cart_item['data']->get_weight() ) && ( $cart_item['data']->get_weight() < $max ) ) {

but not to this: if ( ( $min <= $cart_item['data']->get_weight() ) && ( $cart_item['data']->get_weight() < $max ) ) {

Do you think this can be achieved?

[driade]

Hmm, now that I see what you mean I think that it's clear there's a bug in the current rule, where we've two spaces where it surely must be one. Please let me check.

[PrinceOfAbyss]

Exactly that @driade! Thank you very much!

What's interesting about the bug is that it happens only on the opening side, not the closing one: https://prnt.sc/in0d5iay6aO1

[driade]

There you've, it should be already fixed.

[PrinceOfAbyss]

@driade any ETA on this being released as an update to VS.Code?

[driade]

I'm not entirely sure about how the changes are synced to VSCode. From what I understand, it's fast, but I'm uncertain about the specifics.

[kokororin]

The automatic update script has some issues; version 1.2.1 has been released now.

[PrinceOfAbyss]

Indeed the bug is corrected now! Thanks @kokororin