kokoye2007 / waitzar

Automatically exported from code.google.com/p/waitzar
Other
0 stars 1 forks source link

Help Keyboard Issues #119

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The help keyboard was just re-enabled, and there's a few problems:
  1) Typing "ko" as u-d-k works, but u-k-d (which should be acceptable) is converted wrongly ---there's a hyphen after the 'd'. This is probably a result of having TWO conversions; it worked fine in 1.7.
  2) Typing an unknown word and then trying to type _anything_ else (numbers, known words, other "help keyboard" words) will cause the program to appear to ignore all input.
  3) Type any complex word (e.g., pat-sint) and then hit "F1". The sentence string is forwarded, but the encoding is wrong (this was expected; just not sure how to fix it).

These are the main problems at the moment. Other minor problems were fixed with 
only SVN comments.

Original issue reported on code.google.com by seth.h...@gmail.com on 20 Jun 2010 at 9:07

GoogleCodeExporter commented 9 years ago
3) Fixed. Just passed through a function pointer for "getting an encoding" 
which made things pretty easy. 

Original comment by seth.h...@gmail.com on 20 Jun 2010 at 9:40

GoogleCodeExporter commented 9 years ago
The problem is in waitzar::renderAsZawgyi(). This function could do for some 
cleanup (i.e., "it's still a potential source of pointer errors"), but I'm 
disinclined to thoroughly rework it right now, since I'd rather get at least a 
demo out before potentially breaking encodings. 

Original comment by seth.h...@gmail.com on 20 Jun 2010 at 9:46

GoogleCodeExporter commented 9 years ago
1) Fixed. I'd forgotten to call sortMyanmarString() in the Uni2Zg conversion 
function. We should probably unify these functions at some point; I don't think 
one is ever called without the other.

Actually, perhaps both should go inside Uni2Zg instead of wz_utils? Well, 
anyway....

Original comment by seth.h...@gmail.com on 20 Jun 2010 at 10:07

GoogleCodeExporter commented 9 years ago
2) Fixed. Amazingly related to 1, in that calling sortMyanmarString() on 
unknown sequences would append a '\0' to them, causing untold havoc when that 
string was eventually converted to a wchar_t[]. 

All fixed, closing this issue. That should be _most_ of the Help Keyboard 
related bugs.

Original comment by seth.h...@gmail.com on 20 Jun 2010 at 10:28