search

kokoye2007 / waitzar

Automatically exported from code.google.com/p/waitzar
Other
0 stars 1 forks source link

Backspace doesn't always delete the combiner #133

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Type "|" on the help keyboard (Shift + backslash). It types "႒". Now type 
backspace. You're left with "ဋ^", since the combiner isn't properly deleted. 

This is probably an older bug, but only appears now that we've switched the 
view encoding back to Zawgyi. Still, it represents a problem.

Original issue reported on code.google.com by seth.h...@gmail.com on 25 Aug 2010 at 10:27

GoogleCodeExporter commented 9 years ago 
This happens with most combined letters. 
Try:
  u`
...then back; it leaves the "^" character.

Original comment by seth.h...@gmail.com on 27 Aug 2010 at 7:22

GoogleCodeExporter commented 9 years ago 
In related news, typing "~" when the user has already stacked a letter adds an 
additional "^".

The problem is that we check "IsConsonant()" on the previous letter to see if 
stacking is possible. We should really check:
    IsConsonant(lastLetter) && !IsStacked(lastLetter)

Original comment by seth.h...@gmail.com on 27 Aug 2010 at 7:24

GoogleCodeExporter commented 9 years ago 
Fixed the second bit (typing "~" no longer generates "^"). 
Deleting a "stacked" letter still causes problems... I think it's easiest to 
fix by simply detecting and deleting the "^" letter when it exists instead of 
the consonant.

Original comment by seth.h...@gmail.com on 5 Sep 2010 at 12:27

GoogleCodeExporter commented 9 years ago 
Fixed: now you get ဋဌ, which is technically correct.

Also fixed kinzi & U+1039 in other contexts. Backspace behaves a lot better 
now. 

Tested in non-help mode too, since that uses a different source.

Original comment by seth.h...@gmail.com on 6 Sep 2010 at 7:07